Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tarpc from 0.26.2 to 0.27.2 and add BanksClientError #21739

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2021

Bumps tarpc from 0.26.2 to 0.27.2.

Changelog

Sourced from tarpc's changelog.

0.27.1 (2021-09-22)

Breaking Changes

RPC error type is changing

RPC return types are changing from Result<Response, io::Error> to Result<Response, tarpc::client::RpcError>.

Becaue tarpc is a library, not an application, it should strive to use structured errors in its API so that users have maximal flexibility in how they handle errors. io::Error makes that hard, because it is a kitchen-sink error type.

RPCs in particular only have 3 classes of errors:

  • The connection breaks.
  • The request expires.
  • The server decides not to process the request.

RPC responses can also contain application-specific errors, but from the perspective of the RPC library, those are opaque to the framework, classified as successful responsees.

Open Telemetry

The Opentelemetry dependency is updated to version 0.16.x.

0.27.0 (2021-09-22)

This version was yanked due to tarpc-plugins version mismatches.

0.26.0 (2021-04-14)

New Features

Tracing

tarpc is now instrumented with tracing primitives extended with OpenTelemetry traces. Using a compatible tracing-opentelemetry subscriber like Jaeger, each RPC can be traced through the client, server, amd other dependencies downstream of the server. Even for applications not connected to a distributed tracing collector, the instrumentation can also be ingested by regular loggers like env_logger.

Breaking Changes

Logging

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies rust Pull requests that update Rust code labels Dec 9, 2021
@CriesofCarrots
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/cargo/tarpc-0.27.2 branch from b132582 to 11f3b2d Compare December 20, 2021 23:21
@CriesofCarrots CriesofCarrots force-pushed the dependabot/cargo/tarpc-0.27.2 branch from 1975095 to cd2b444 Compare December 20, 2021 23:25
@CriesofCarrots CriesofCarrots added the work in progress This isn't quite right yet label Dec 20, 2021
@CriesofCarrots CriesofCarrots changed the title chore: bump tarpc from 0.26.2 to 0.27.2 [wip] chore: bump tarpc from 0.26.2 to 0.27.2 Dec 20, 2021
@CriesofCarrots CriesofCarrots force-pushed the dependabot/cargo/tarpc-0.27.2 branch 2 times, most recently from 8440cfa to be9e707 Compare December 21, 2021 04:16
@CriesofCarrots CriesofCarrots removed the work in progress This isn't quite right yet label Dec 21, 2021
@CriesofCarrots CriesofCarrots changed the title [wip] chore: bump tarpc from 0.26.2 to 0.27.2 bump tarpc from 0.26.2 to 0.27.2 and add BanksClientError Dec 21, 2021
@CriesofCarrots CriesofCarrots force-pushed the dependabot/cargo/tarpc-0.27.2 branch from be9e707 to 0d6dbab Compare December 21, 2021 04:37
@CriesofCarrots CriesofCarrots force-pushed the dependabot/cargo/tarpc-0.27.2 branch from 0d6dbab to 90f9d37 Compare December 21, 2021 04:55
joncinque
joncinque previously approved these changes Dec 21, 2021
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@CriesofCarrots CriesofCarrots added automerge Merge this Pull Request automatically once CI passes and removed v1.9 labels Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #21739 (9d08483) into master (d896ff7) will decrease coverage by 0.0%.
The diff coverage is 69.1%.

@@            Coverage Diff            @@
##           master   #21739     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         517      518      +1     
  Lines      145586   145728    +142     
=========================================
+ Hits       118445   118506     +61     
- Misses      27141    27222     +81     

@mergify mergify bot merged commit ddde356 into master Dec 22, 2021
@dependabot dependabot bot deleted the dependabot/cargo/tarpc-0.27.2 branch December 22, 2021 02:31
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes dependencies locked PR rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants