Fixup flaky tests #21617
Merged
Fixup flaky tests #21617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 |
Codecov Report
@@ Coverage Diff @@
## master #21617 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 510 510
Lines 142504 142504
=========================================
- Hits 116401 116388 -13
- Misses 26103 26116 +13 |
carllin
force-pushed
the
FixLocalClusterTests
branch
from
2b393aa to
9eec5a9
Compare
carllin
force-pushed
the
FixLocalClusterTests
branch
from
9eec5a9 to
2230b2e
Compare
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Fixup flaky tests * Fixup listeners (cherry picked from commit f493a88) # Conflicts: # local-cluster/tests/local_cluster.rs
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Fixup flaky tests * Fixup listeners (cherry picked from commit f493a88)
carllin
added a commit
that referenced
this pull request
Dec 7, 2021
* Fixup flaky tests * Fixup listeners
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2021
* Fixup flaky tests * Fixup listeners (cherry picked from commit f493a88) Co-authored-by: carllin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2021
* Fix fork race condition in optimistic violation tower tests (#19192) * Fix fork race condition in optimistic violation tower tests * clippy * pr comments * Fixup flaky tests (#21617) * Fixup flaky tests * Fixup listeners Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: carllin <[email protected]>
tao-stones
pushed a commit
that referenced
this pull request
Dec 13, 2021
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…a-labs#21646)"" This reverts commit 156caeb.
CriesofCarrots
pushed a commit
that referenced
this pull request
Dec 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
do_test_optimistic_confirmation_violation_with_or_without_tower()local cluster tests are flaky for a few reasons:If the cluster immediately forks on restart while we're killing validators A and C, with Validator B on one side, and
AandCon a heavier fork, it's possible that the lockouts onAandC's latest votes do not extend past validator B's latest vote. Then validator B will be stuck unable to vote, but also unable generate a switching proof to the heavier fork.Validator A can vote past
next_slot_on_abefore we can kill it at the beginning of the test. When we then copy over validator B's ledger below only for slots <=next_slot_on_a, then validator A loses the slot it last voted onnext_slot_on_afrom its ledger, even though it retains it in its tower. Thus it will not know how its last vote chains to thebase_slot, and will thus count votes for ancestors of its last vote towards the switching proof, and thus may violate switching proofs on restart.Summary of Changes
Fixes #