Make StakeHistory clone-on-write #21573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
commented
Dec 2, 2021
Comment on lines
+8
to
+10
| /// The SDK's stake history with clone-on-write semantics | ||
| #[derive(Default, Clone, PartialEq, Debug, Deserialize, Serialize, AbiExample)] | ||
| pub struct StakeHistory(Arc<StakeHistoryInner>); |
There was a problem hiding this comment.
Similar to StageDelegations in #21542, we need an Arc here since banks are sent across threads (i.e. the accounts background services).
runtime/src/serde_snapshot/tests.rs
Outdated
| @@ -312,7 +312,7 @@ mod test_bank_serialize { | |||
|
|
|||
| // This some what long test harness is required to freeze the ABI of | |||
| // Bank's serialization due to versioned nature | |||
| #[frozen_abi(digest = "5vYNtKztrNKfb6TtRktXdLCbU73rJSWhLwguCHLvFujZ")] | |||
| #[frozen_abi(digest = "BJQdQMuXV3349GUWo9Gq3wqxbxV1hJ1jjq9JmXBY3zRV")] | |||
There was a problem hiding this comment.
Assuming #21542 gets merged first, this digest will need to change again.
| @@ -14,7 +17,6 @@ use { | |||
| self, | |||
| state::{Delegation, StakeActivationStatus, StakeState}, | |||
| }, | |||
| stake_history::StakeHistory, | |||
There was a problem hiding this comment.
Pretty nice! The only visible change to stakes.rs is where to get StakeHistory from.
Codecov Report
@@ Coverage Diff @@
## master #21573 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 508 509 +1
Lines 142340 142380 +40
=======================================
+ Hits 116155 116243 +88
+ Misses 26185 26137 -48 |
jstarry
previously approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stake history is cloned into every bank, regardless if is is changed or not.
Summary of Changes
Implement clone-on-write semantics for stake history.