feat(tree-shaking): enable browser target webpack tree-shaking #21055
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| const isCalledByBundler = caller => caller.name.startsWith('@rollup'); | ||
|
|
||
| module.exports = api => { | ||
| const calledByBundler = api.caller(isCalledByBundler); | ||
| const transformEnvVariables = | ||
| !calledByBundler && | ||
| process.env.NODE_ENV && | ||
| process.env.BROWSER !== undefined; | ||
|
|
||
| return { | ||
| presets: [ | ||
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| modules: false, | ||
| bugfixes: true, | ||
| }, | ||
| ], | ||
| ['@babel/preset-typescript'], | ||
| ], | ||
| plugins: [ | ||
| [ | ||
| '@babel/plugin-proposal-class-properties', | ||
| { | ||
| loose: true, | ||
| }, | ||
| ], | ||
| [ | ||
| '@babel/plugin-proposal-private-methods', | ||
| { | ||
| loose: true, | ||
| }, | ||
| ], | ||
| [ | ||
| '@babel/plugin-proposal-private-property-in-object', | ||
| { | ||
| loose: true, | ||
| }, | ||
| ], | ||
| transformEnvVariables && [ | ||
| 'transform-inline-environment-variables', | ||
| { | ||
| include: ['NODE_ENV', 'BROWSER'], | ||
| }, | ||
| ], | ||
| transformEnvVariables && [ | ||
| 'minify-dead-code-elimination', | ||
|
There was a problem hiding this comment. If we consider https://github.com/solana-labs/solana/pull/21055/files#r759707513, then this becomes unnecessary as well, the consumer's bundler / minifier will remove the bit of dead code: if (!process.env.BROWSER) {
agentManager = new AgentManager(useHttps);
} |
||
| { | ||
| keepFnName: true, | ||
| keepFnArgs: true, | ||
| keepClassName: true, | ||
| }, | ||
| ], | ||
| transformEnvVariables && [ | ||
| 'babel-plugin-transform-remove-imports', | ||
| { | ||
| test: 'agent-manager', | ||
|
There was a problem hiding this comment. Not really satisfied by this solution, forces the build to be aware that a specific import is unused in specific conditions ̛& needs to be removed. I believe it might be best to not remove the import, and in fact ship the code containing references to |
||
| }, | ||
| ], | ||
| ].filter(Boolean), | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This on the other hand, I think is good to keep in any case, since it enables not forcing consumers to inject themselves inlined
process.env.BROWSER&process.env.NODE_ENVvalues in their builds (even though,process.env.NODE_ENVis injected by most bundlers automatically today)