AcctIdx: cleanup bg threads #20731
Merged
AcctIdx: cleanup bg threads #20731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
metrics5
branch
from
bc8ce99 to
07f6ad9
Compare
brooksprumo
previously approved these changes
Oct 15, 2021
Comment on lines
14
to
15
| // bg_threads is 'never used'. It is only used to manage the lifetime | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Instead of the #[allow(dead_code)], would an underscore on bg_threads work too? (i.e. _bg_threads)
There was a problem hiding this comment.
good idea. done.
jeffwashington
force-pushed
the
metrics5
branch
from
07f6ad9 to
f28f636
Compare
mergify
bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
brooksprumo
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #20731 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 495 495
Lines 138041 138092 +51
=========================================
- Hits 113072 113060 -12
- Misses 24969 25032 +63 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 25, 2021
This reverts part of commit 47de4f3.
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 25, 2021
This reverts part of commit 47de4f3.
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 26, 2021
This reverts part of commit 47de4f3.
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 26, 2021
This reverts part of commit 47de4f3.
jeffwashington
added a commit
that referenced
this pull request
Oct 26, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Revert part of "AcctIdx: cleanup bg threads (solana-labs#20731)" This reverts part of commit 47de4f3. * change bg waiting metrics to percent
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 7708869.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Refactoring, cleanup to make bg threads and lifetimes more clear.
Also got rid of threads on BucketMapHolder
Summary of Changes
Fixes #