Free up the term 'replicate' for exclusive use in ledger replication #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgarg66, added you to review in the context of counter names. There's no tests protecting those strings. The test suite lets me change them with no regard for the implications. |
|
@garious , changing the string names would also require to update metrics dashboard. |
garious
force-pushed
the
rename-replicate
branch
2 times, most recently
from
359671e to
54a1e5e
Compare
|
@sakridge, @sagar-solana, still waiting on you guys. Are you okay with these name changes? |
Also, align Sockets field names with ContactInfo.
garious
force-pushed
the
rename-replicate
branch
from
54a1e5e to
8614796
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* Fix signer parameters (staker, manager, depositor, fee-payer, and token-owner) * On deposit / withdraw / add / remove validator, show the validator stake account and where the stake is going to
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Jul 9, 2024
Bumps solana_rbpf to v0.8.2 and removes switch_to_new_elf_parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replication code is using name "storage" to avoid interfering with the term replicate that's been awkwardly used by the TVU to describe the stage that replays the ledger.
Summary of Changes
ReplicateStagetoReplayStagecc: #1409