Add get_incremental_snapshot_hash_for_node() to gossip #20394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
iss-crds-get
branch
from
3318716 to
9e25662
Compare
brooksprumo
force-pushed
the
iss-crds-get
branch
from
9e25662 to
28e7170
Compare
Codecov Report
@@ Coverage Diff @@
## master #20394 +/- ##
=======================================
Coverage 82.2% 82.2%
=======================================
Files 492 492
Lines 137251 137258 +7
=======================================
+ Hits 112874 112887 +13
+ Misses 24377 24371 -6 |
brooksprumo
force-pushed
the
iss-crds-get
branch
from
28e7170 to
c23defe
Compare
brooksprumo
force-pushed
the
iss-crds-get
branch
from
c23defe to
72de632
Compare
|
@behzadnouri This PR is ready for review. Let me know if you need anything. Thanks in advance! |
behzadnouri
reviewed
Oct 7, 2021
brooksprumo
force-pushed
the
iss-crds-get
branch
from
72de632 to
552f31c
Compare
behzadnouri
reviewed
Oct 7, 2021
behzadnouri
approved these changes
Oct 7, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…a-labs#20394)" This reverts commit c7e37c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to retrieve incremental snapshot hashes from CRDS.
Summary of Changes
Add fn to get incremental snapshot hashes, from CRDS, for a node.
Fixes #20377