Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds unprefixed_malloc_on_supported_platforms to jemalloc #20317

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

behzadnouri
Copy link
Contributor

@behzadnouri behzadnouri commented Sep 29, 2021

Problem

Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
#14366 (comment)

Summary of Changes

added the feature

Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this means we can't blame rocksdb for heap fragmentation

@mvines mvines added the v1.7 label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #20317 (187dc0b) into master (4de5fff) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #20317     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         485      485             
  Lines      135887   135887             
=========================================
- Hits       112615   112573     -42     
- Misses      23272    23314     +42     

@behzadnouri behzadnouri merged commit 4bf6d0c into solana-labs:master Sep 29, 2021
@behzadnouri behzadnouri deleted the jemalloc-noprefix branch September 29, 2021 20:41
mergify bot pushed a commit that referenced this pull request Sep 29, 2021
Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
#14366 (comment)

(cherry picked from commit 4bf6d0c)
mergify bot added a commit that referenced this pull request Sep 29, 2021
…20325)

Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
#14366 (comment)

(cherry picked from commit 4bf6d0c)

Co-authored-by: behzad nouri <[email protected]>
im-0 added a commit to im-0/solana that referenced this pull request Sep 30, 2021
…llocator

Trivial typo fix.

Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (solana-labs#20317)")
CriesofCarrots pushed a commit that referenced this pull request Sep 30, 2021
…llocator (#20351)

Trivial typo fix.

Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (#20317)")
mergify bot pushed a commit that referenced this pull request Sep 30, 2021
…llocator (#20351)

Trivial typo fix.

Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (#20317)")
(cherry picked from commit 8ae8863)
mergify bot added a commit that referenced this pull request Sep 30, 2021
…llocator (#20351) (#20354)

Trivial typo fix.

Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (#20317)")
(cherry picked from commit 8ae8863)

Co-authored-by: Ivan Mironov <[email protected]>
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
…s#20317)

Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
solana-labs#14366 (comment)
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
…llocator (solana-labs#20351)

Trivial typo fix.

Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (solana-labs#20317)")
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants