-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds unprefixed_malloc_on_supported_platforms to jemalloc #20317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this feature jemalloc is used only for Rust code but not for bundled C/C++ libraries (like rocksdb).
mvines
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this means we can't blame rocksdb for heap fragmentation
Codecov Report
@@ Coverage Diff @@
## master #20317 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 485 485
Lines 135887 135887
=========================================
- Hits 112615 112573 -42
- Misses 23272 23314 +42 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
Without this feature jemalloc is used only for Rust code but not for bundled C/C++ libraries (like rocksdb). #14366 (comment) (cherry picked from commit 4bf6d0c)
mergify bot
added a commit
that referenced
this pull request
Sep 29, 2021
…20325) Without this feature jemalloc is used only for Rust code but not for bundled C/C++ libraries (like rocksdb). #14366 (comment) (cherry picked from commit 4bf6d0c) Co-authored-by: behzad nouri <[email protected]>
im-0
added a commit
to im-0/solana
that referenced
this pull request
Sep 30, 2021
…llocator Trivial typo fix. Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (solana-labs#20317)")
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…s#20317) Without this feature jemalloc is used only for Rust code but not for bundled C/C++ libraries (like rocksdb). solana-labs#14366 (comment)
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…llocator (solana-labs#20351) Trivial typo fix. Fixes: 4bf6d0c ("adds unprefixed_malloc_on_supported_platforms to jemalloc (solana-labs#20317)")
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…lana-labs#20317)" This reverts commit a63fea0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without this feature jemalloc is used only for Rust code but not for
bundled C/C++ libraries (like rocksdb).
#14366 (comment)
Summary of Changes
added the feature