-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fee schedule in cost calculation #20314
Implement fee schedule in cost calculation #20314
Conversation
86256ea
to
d9aac34
Compare
d9aac34
to
46a987a
Compare
Codecov Report
@@ Coverage Diff @@
## master #20314 +/- ##
=========================================
- Coverage 82.3% 82.2% -0.2%
=========================================
Files 497 492 -5
Lines 136959 137286 +327
=========================================
+ Hits 112854 112952 +98
- Misses 24105 24334 +229 |
Great stuff! We want to switch the fee calculation from just sigs to using these calculated tx costs. What do you think about passing a We also need to make these fee calculations available for transaction simulation. Maybe we give banks a ref to the cost tracker? We should also be incorporating the cost of the account data sizes. We could feed that information back to the cost tracker like we currently do for execution costs. If an account size is not in the cache we could keep a list of account size averages per program. |
Yea, was thinking to actually move |
Yea, perhaps it can fit into bankless leader process: banking stage get tx cost from cost model, before it loads accounts to check balance, it can use fee governor to convert cost into fee; Is this what you are thinking? |
That would be great! want to create a ticket for it? |
banking stage is already calculating the cost of each tx in order to schedule, rather than re-calc again later just pass this info along |
#20511 , once the info is fed to cost model, I can update the calculation to incorporate it. |
- update cost calculation to closely proposed fee schedule solana-labs#16984
46a987a
to
80fa77d
Compare
…olana-labs#20314) - update cost calculation to closely proposed fee schedule solana-labs#16984
…#19627 (solana-labs#20314)" This reverts commit 573e57d.
Problem
fee schedule should be implemented in cost calculation.
Summary of Changes
Fixes #