Refactor: Merge message processor into invoke context #20308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process_message().
…ssageProcessor::process_message().
…process_message().
…rocessor ::process_message().
…sor::verify() into InvokeContext::verify().
Codecov Report
@@ Coverage Diff @@
## master #20308 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 485 485
Lines 135809 135887 +78
=======================================
+ Hits 112496 112567 +71
- Misses 23313 23320 +7 |
|
I confirmed this makes new roots against mnb and rebased against master. @Lichtso asked me to merge this. |
Lichtso
deleted the
refactor/merge_message_processor_into_invoke_context
branch
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
) * Inlines MessageProcessor::execute_instruction() in MessageProcessor::process_message(). * Moves MessageProcessor::create_pre_accounts() into ThisInvokeContext::push(). * Move instruction_recorders slice into InvokeContext. * Makes account_indices optional in InvokeContext::push(). * Separates initial InvokeContext::push() from ThisInvokeContext::new(). * invoke_context.pop() the base invocation frame. * Zip message.instructions.iter() and program_indices.iter(). * Moves ThisInvokeContext::new() to the beginning of the loop inside MessageProcessor::process_message(). * Hoists ThisInvokeContext::new() out of loop inside MessageProcessor::process_message(). * Removes unnecessary clone() from ThisInvokeContext::new() in MessageProcessor ::process_message(). * Stop ignoring errors from MessageProcessor::create_pre_accounts(). * Moves MessageProcessor::verify_account_references() and MessageProcessor::verify() into InvokeContext::verify().
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…-labs#20308)" This reverts commit 0bd8330.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20165 (which was reverted in #20301) had the following problem:
The feature flag
tx_wide_compute_capwas left inThisInvokeContext::new(). So it was only applied per transaction, not applied to each instruction, as the constructor got hoisted out of the loop. It diverged on MB and not the CI tests, as the feature flag is activated by default in the tests, but not yet active on MB.Summary of Changes
The application of the feature flag was moved from
ThisInvokeContext::new()toInvokeContext::set_instruction_index().See: c579bd8
Fixes #