Add metric measuring number of successfully inserted push messages #20275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
reviewed
Sep 27, 2021
behzadnouri
reviewed
Sep 28, 2021
gossip/src/cluster_info_metrics.rs
Outdated
| @@ -109,6 +109,7 @@ pub(crate) struct GossipStats { | |||
| pub(crate) new_push_requests2: Counter, | |||
| pub(crate) new_push_requests: Counter, | |||
| pub(crate) new_push_requests_num: Counter, | |||
| pub(crate) process_push_success: Counter, | |||
There was a problem hiding this comment.
can we plz keep this list sorted?
behzadnouri
reviewed
Sep 28, 2021
gossip/src/crds_gossip.rs
Outdated
| let results = self | ||
| .push | ||
| .process_push_message(&self.crds, from, values, now); | ||
| let success_count = results.len(); |
There was a problem hiding this comment.
the inserted ones are the ones which are not error.
results.len() is the same as values.len().
There was a problem hiding this comment.
Ick, need to read more carefully. Fixed up, thanks!
Codecov Report
@@ Coverage Diff @@
## master #20275 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 487 487
Lines 135612 135624 +12
=======================================
+ Hits 112295 112309 +14
+ Misses 23317 23315 -2 |
behzadnouri
approved these changes
Sep 29, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…olana-labs#20275) * Add number of successfully inserted push messages
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…sages (solana-labs#20275)" This reverts commit 9af1dfe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No easy way to tell ratio of new messages coming in from push vs pull to measure how effective push in the network currently is
Summary of Changes
Add a
process_push_successmetric that is a parallel to theprocess_pull_response_successmetricFixes #