Make bigtable delete-slots actually usable #20037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Sep 20, 2021
| @@ -439,7 +439,7 @@ pub fn bigtable_process_command(ledger_path: &Path, matches: &ArgMatches<'_>) { | |||
| } | |||
| ("delete-slots", Some(arg_matches)) => { | |||
| let slots = values_t_or_exit!(arg_matches, "slots", Slot); | |||
| let dry_run = !value_t_or_exit!(arg_matches, "force", bool); | |||
There was a problem hiding this comment.
no way to go past this ..._or_exit!() given this:
solana/ledger-tool/src/bigtable.rs
Line 292 in d6d2840
There was a problem hiding this comment.
Sorry about that lack of testing
jstarry
approved these changes
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #20037 +/- ##
=========================================
+ Coverage 82.6% 82.8% +0.2%
=========================================
Files 478 487 +9
Lines 133547 134800 +1253
=========================================
+ Hits 110369 111680 +1311
+ Misses 23178 23120 -58 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
(cherry picked from commit 22f45dc)
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
(cherry picked from commit 22f45dc)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 20, 2021
mergify bot
added a commit
that referenced
this pull request
Sep 20, 2021
(cherry picked from commit 22f45dc) Co-authored-by: Ryo Onodera <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 21, 2021
(cherry picked from commit 22f45dc) Co-authored-by: Ryo Onodera <[email protected]>
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit f56e178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
seems last-minute review adjustments made
solana-ledger-tool bigtable delete-slotsnot workable at all (with/without--force)Summary of Changes
context: #19931