This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
CPI without Account Refs #20034
Merged
Lichtso
merged 3 commits into
solana-labs:master
from
Lichtso:refactor/cpi_without_account_refs
Sep 21, 2021
Merged
CPI without Account Refs #20034
Lichtso
merged 3 commits into
solana-labs:master
from
Lichtso:refactor/cpi_without_account_refs
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/cpi_without_account_refs
branch
from
September 20, 2021 14:00
c032a78
to
87cf637
Compare
…ss_cross_program_instruction().
Lichtso
force-pushed
the
refactor/cpi_without_account_refs
branch
from
September 20, 2021 17:11
87cf637
to
dbc9918
Compare
jstarry
reviewed
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, noticed something while reading your change
Codecov Report
@@ Coverage Diff @@
## master #20034 +/- ##
=========================================
+ Coverage 82.6% 82.8% +0.1%
=========================================
Files 478 487 +9
Lines 133547 134784 +1237
=========================================
+ Hits 110369 111651 +1282
+ Misses 23178 23133 -45 |
Co-authored-by: Justin Starry <[email protected]>
jstarry
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, it also looks like this change makes #9711 trivial to implement
Closed
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Removes search for accounts and unsafe lifetime transmute in InvokeContext::push(). * Replaces accounts by account_indices in verify_and_update() and process_cross_program_instruction(). Co-authored-by: Justin Starry <[email protected]>
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 6f058b8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#15410 introduced this
unsafe
expression.Summary of Changes
unsafe
lifetime transmute inInvokeContext::push()
.Fixes #