Free up term "finality" to imply "economic finality" #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free up term "finality" to imply "economic finality."
rob-solana
approved these changes
Dec 4, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* chore: upgrade instruction serialisation * chore: add assert for base64 encoded instruction * chore: move fields with dynamic size to account end * chore: Add VoteThresholdPercentageType to support quorum votes in future versions * chore: Add VoteWeightSource to support account snapshots as voter weights in future versions * chore: Add InstructionExecutionStatus to support failing proposal instructions in future versions * fix: update voting_at_slot when proposal enters voting state * fix: change min_tokens_to_create_proposal to u64 to support large mints * chore: add InstructionExecutionFlags to support ordered and transactional instruction in future versions * chore: add withdraw tests with relinquished and unrelinquished votes * chore: add placeholder for proposal_cool_off_time * chore: add padding to permanent accounts to use in future versions * chore: add ProposalCoolOffTimeNotSupported error * chore: start governance errors from 500 * chore: update versions * chore: update comments * chore: use slice for reserved account space * chore: use VoteThresholdPercentage enum to store percentage value * chore: use enum None value instead of Option for execution_status * chore: use enum None instead of Option for execution_flags * chore: make clippy happy Co-authored-by: Jon Cinque <[email protected]>
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Jul 18, 2024
… (solana-labs#2002) * Remove assorted deprecated symbols (solana-labs#1995) * Remove deprecated method from program-test * Remove deprecated programs stuff from TestValidator * Remove deprecated method from TestValidator (deprecated in v1.11.0) * Remove deprecated re-export from cluster_info (cherry picked from commit efdbdc0) # Conflicts: # gossip/src/cluster_info.rs * Fix conflict --------- Co-authored-by: Tyera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I recently started qualifying our use of the term "finality" as "leader finality" to distinguish it from "economic finality," but that's still confusing.
Summary of Changes