Separate tpu vote port #20007
Closed
Separate tpu vote port #20007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd add Line 690 in f579f73 |
added, thanks |
Codecov Report
@@ Coverage Diff @@
## v1.6 #20007 +/- ##
=========================================
- Coverage 82.4% 82.4% -0.1%
=========================================
Files 426 426
Lines 119288 119433 +145
=========================================
+ Hits 98338 98432 +94
- Misses 20950 21001 +51 |
jstarry
reviewed
Sep 19, 2021
tao-stones
force-pushed
the
tpu-vote
branch
from
0fe5501 to
d7d0edb
Compare
tao-stones
reviewed
Sep 21, 2021
tao-stones
force-pushed
the
tpu-vote
branch
from
1eeee7a to
3243acc
Compare
tao-stones
force-pushed
the
tpu-vote
branch
from
a97f63e to
58cc200
Compare
tao-stones
force-pushed
the
tpu-vote
branch
from
58cc200 to
ed703d4
Compare
jstarry
reviewed
Sep 23, 2021
core/src/banking_stage.rs
Outdated
| } else { | ||
| // Disable forwarding of vote transactions, as votes are gossiped | ||
| (verified_vote_receiver.clone(), false) | ||
| let (verified_receiver, enable_forwarding) = match i.cmp(&(num_threads - 2)) { |
There was a problem hiding this comment.
The compare match is pretty convoluted, how about 0 is the gossip vote receiver, 1 is the tpu vote receiver and the rest of the indices are for normal banking threads?
added |
tao-stones
force-pushed
the
tpu-vote
branch
from
821978b to
55db1d1
Compare
tao-stones
force-pushed
the
tpu-vote
branch
from
55db1d1 to
f07ee32
Compare
tao-stones
force-pushed
the
tpu-vote
branch
from
f07ee32 to
0870fff
Compare
jstarry
approved these changes
Sep 25, 2021
|
Merged in v1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Votes can get effectively de-prioritized in the regular transaction queue.
Summary of Changes
Add a special vote-only TPU port.
Fixes #