Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and standardize precompiles #19918

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Sep 15, 2021

Problem

Precompiled programs take the same inputs and provide the same outputs but are handled separately. They are also handled disjointly which makes working with pre-compiled programs as a whole messy

Summary of Changes

The last two points will be addressed in follow-up PRs. This PR should contain no behavior changes and thus does not contain any featurization.

Fixes #

@jackcmay jackcmay force-pushed the improve-precompile-programs branch from 0d9f739 to ea8f826 Compare September 15, 2021 20:26
@jackcmay jackcmay added noCI Suppress CI on this Pull Request CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request CI Pull Request is ready to enter CI labels Sep 15, 2021
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #19918 (ea8f826) into master (b467e7f) will increase coverage by 0.0%.
The diff coverage is 91.9%.

@@           Coverage Diff            @@
##           master   #19918    +/-   ##
========================================
  Coverage    82.6%    82.6%            
========================================
  Files         478      479     +1     
  Lines      133455   133470    +15     
========================================
+ Hits       110261   110375   +114     
+ Misses      23194    23095    -99     

@jackcmay jackcmay requested a review from jstarry September 16, 2021 03:50
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@jackcmay jackcmay merged commit fc2bf2d into solana-labs:master Sep 17, 2021
@jackcmay jackcmay deleted the improve-precompile-programs branch September 17, 2021 18:37
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants