Add banking metrics for buffered and dropped packets #19902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
more-banking-metrics
branch
from
f946f18 to
cd26fd1
Compare
jstarry
force-pushed
the
more-banking-metrics
branch
from
cd26fd1 to
f52a5c7
Compare
jstarry
force-pushed
the
more-banking-metrics
branch
from
f52a5c7 to
1ed53fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #19902 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 478 478
Lines 133443 133460 +17
=========================================
- Hits 110334 110325 -9
- Misses 23109 23135 +26 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
(cherry picked from commit ca3f147)
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
(cherry picked from commit ca3f147)
mergify bot
added a commit
that referenced
this pull request
Sep 16, 2021
(cherry picked from commit ca3f147) Co-authored-by: Justin Starry <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 16, 2021
(cherry picked from commit ca3f147) Co-authored-by: Justin Starry <[email protected]>
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…labs#19902)" This reverts commit 6b9186b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Buffered packet metric and dropped packet metrics only report the number of "packet batches" and it's not possible to know how many packets are in each batch (could be at most 128)
Summary of Changes
Add extra metrics for the actual number of packets dropped and currently buffered
Fixes #