create remove_if_slot_list_empty to define accounts index behavior #19581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
approved these changes
Sep 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #19581 +/- ##
=========================================
- Coverage 82.5% 82.4% -0.1%
=========================================
Files 468 468
Lines 131542 131547 +5
=========================================
- Hits 108575 108521 -54
- Misses 22967 23026 +59 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 2, 2021
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 3, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…avior (solana-labs#19581)" This reverts commit 4480ea2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This function has complicated interactions with an on-disk index. This refactoring makes the second step more clear.
Summary of Changes
Fixes #