docs: update spl token exchange integration #19573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
previously approved these changes
Sep 2, 2021
|
this goes into way more details. are we at the point that we can do the same for tokens? https://docs.solana.com/integrations/exchange#poll-for-blocks |
mvines
previously approved these changes
Sep 2, 2021
Yeah we reference this section from the SPL Token deposits section |
Good call! We'll inevitably get some push back, but we can handle that on a case by case basis |
Co-authored-by: Michael Vines <[email protected]>
mergify
bot
dismissed stale reviews from aeyakovenko and mvines
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
* docs: update spl token exchange integration * Apply suggestions from code review Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]> (cherry picked from commit f4f14c4)
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2021
* docs: update spl token exchange integration * Apply suggestions from code review Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]> (cherry picked from commit f4f14c4) Co-authored-by: Trent Nelson <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 2, 2021
* docs: update spl token exchange integration * Apply suggestions from code review Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 3, 2021
* docs: update spl token exchange integration * Apply suggestions from code review Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]>
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 1d3bfd6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPL Token exchange integration docs are outdated. Missing best practices use of ATAs, token balance checks and modern instruction names
Summary of Changes
Update them