add synchronization comment to handle_new_root #19571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
previously approved these changes
Sep 2, 2021
mergify
bot
dismissed
carllin’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #19571 +/- ##
=======================================
Coverage 82.5% 82.5%
=======================================
Files 468 468
Lines 131542 131542
=======================================
+ Hits 108540 108570 +30
+ Misses 23002 22972 -30 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 2, 2021
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 3, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
handle_new_root() acquires a write lock on bank_forks, drops the lock, acquires a read lock, and looks up the new_root added under the write lock. Because bank_forks is only updated by a single thread this is safe. See: fix race in handle_new_root #18984
Summary of Changes
Add a comment to describe why this is safe.