This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add executor using the program's id during deploy #19555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
approved these changes
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #19555 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 462 461 -1
Lines 131252 131203 -49
=========================================
- Hits 108614 108545 -69
- Misses 22638 22658 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
(cherry picked from commit 622a6fb)
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2021
(cherry picked from commit 622a6fb) Co-authored-by: Jack May <[email protected]>
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All deploys add an executor associated with the loader's id, not the program id. This isn't really an issue because the program gets added to the executor list the first time it is executed, but it's wasteful to add it as the loader.
Summary of Changes
Use the correct program id
Fixes #