tests which assert or panic in other threads now will report an error #19532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
reviewed
Sep 2, 2021
runtime/src/bank.rs
Outdated
| @@ -12976,12 +12976,17 @@ pub(crate) mod tests { | |||
| // Let threads run for a while, check the scans didn't see any mixed slots | |||
| let min_expected_number_of_scans = 5; | |||
| std::thread::sleep(Duration::new(5, 0)); | |||
| let mut loops = 1000; | |||
There was a problem hiding this comment.
nit: loops -> remaining_loops
carllin
previously approved these changes
Sep 2, 2021
mergify
bot
dismissed
carllin’s stale review
Pull request has been modified.
carllin
approved these changes
Sep 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #19532 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 462 462
Lines 131268 131272 +4
=======================================
+ Hits 108600 108624 +24
+ Misses 22668 22648 -20 |
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…an error (solana-labs#19532)" This reverts commit f90e9ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests calling this function have a tendency to fail in a thread. The result is the test hangs and we get no report of an error.
Summary of Changes
Only wait for the test to finish for 100s. If it takes longer than that, then join the other threads so we can get the failure message.
Fixes #