This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Revert "Add snapshot_runtime_info module (#18199)" #19530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c1b9d40.
Codecov Report
@@ Coverage Diff @@
## master #19530 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 462 461 -1
Lines 131268 131198 -70
=======================================
- Hits 108600 108562 -38
+ Misses 22668 22636 -32 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The snapshot_runtime_info_module is not used. This was originally meant to be how incremental snapshot support would be added to the background services, but a different implementation has been used instead (see PR #19401 if interested).
Summary of Changes
This reverts commit c1b9d40, which removes the snapshot_runtime_info module.