Revert "Add LastFullSnapshotSlot to SnapshotConfig (#19341)" #19529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19529 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 462 461 -1
Lines 131252 131197 -55
=========================================
- Hits 108614 108505 -109
- Misses 22638 22692 +54 |
This reverts commit 4d361af.
brooksprumo
force-pushed
the
remove-last-full-snapshot-2
branch
from
517855c to
8517e3e
Compare
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…bs#19341)" (solana-labs#19529)" This reverts commit 51d538d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LastFullSnapshotSlot is no longer used.
This was the meant to be the second version of how incremental snapshot support would be added to the background services, but a different implementation has been used instead (see PR #19401 if interested).
Summary of Changes
This reverts commit 4d361af, which removes LastFullSnapshotSlot.