add test for test_clean_nonrooted #19409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
non-clean-master_test_only
branch
from
dce50e4 to
8c18e80
Compare
|
@sakridge and I decided this test likely has some value. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
(cherry picked from commit 535de3b)
|
Marking as backport 1.7 so that the test at least runs in the ci against 1.7 in case we learn something. Or, if we want to merge it to 1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
issue: #19320
A test @sakridge wrote that helps confirm we are correctly cleaning
Summary of Changes
Fixes #