Use last_valid_block_height in services and client apps

[CriesofCarrots]

Problem

last_valid_slot is deprecated, and all clusters now support block-height RPCs.

Summary of Changes

Update SendTransactionService, solana program, and solana-tokens CLI to use last_valid_block_height

[CriesofCarrots]

@mvines , can you please look at the SendTransactionService changes? I don't think there should be any breakage for anyone, but would appreciate the sanity check.
Also, should I include BanksClient/BanksServer? Those changes will be more breaking (updating get_fees_with_commitment_and_context to return a block height, instead of a slot). But maybe nbd, if those crates are only being used for program tests.

[mvines]

@mvines , can you please look at the SendTransactionService changes? I don't think there should be any breakage for anyone, but would appreciate the sanity check.

lgtm

Also, should I include BanksClient/BanksServer? Those changes will be more breaking (updating get_fees_with_commitment_and_context to return a block height, instead of a slot). But maybe nbd, if those crates are only being used for program tests.

yeah that's probably the right thing to do even though it's a little breaky. It'll only affect program tests so shouldn't be too painful 🤞🏼

Pull request has been modified.

[codecov]

Codecov Report

Merging #19163 (de0d4b8) into master (fd93754) will increase coverage by 0.0%.
The diff coverage is 89.5%.

@@           Coverage Diff            @@
##           master   #19163    +/-   ##
========================================
  Coverage    82.9%    82.9%            
========================================
  Files         450      453     +3     
  Lines      128336   129053   +717     
========================================
+ Hits       106411   107102   +691     
- Misses      21925    21951    +26