Version transaction message and add new message format #18725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
commented
Jul 16, 2021
jstarry
force-pushed
the
versioned-message
branch
4 times, most recently
from
4636482 to
00944eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #18725 +/- ##
=========================================
- Coverage 82.9% 82.9% -0.1%
=========================================
Files 450 453 +3
Lines 128342 128686 +344
=========================================
+ Hits 106429 106705 +276
- Misses 21913 21981 +68 |
ryoqun
reviewed
Jul 19, 2021
ryoqun
reviewed
Jul 19, 2021
ryoqun
reviewed
Jul 19, 2021
ryoqun
reviewed
Jul 19, 2021
ryoqun
reviewed
Jul 20, 2021
jstarry
force-pushed
the
versioned-message
branch
from
187eaf7 to
22e23c8
Compare
sakridge
reviewed
Jul 21, 2021
| pub num_readonly_signed_accounts: u8, | ||
| pub num_readonly_unsigned_accounts: u8, | ||
| #[serde(with = "short_vec")] | ||
| pub account_keys: Vec<Pubkey>, |
There was a problem hiding this comment.
the duplication here is unfortunate
There was a problem hiding this comment.
Agreed, I spent a fair bit of time trying to "peek" at the first element to avoid this but couldn't get to a good solution. I'll add a comment in the Message struct pointing to this code.
sakridge
reviewed
Jul 21, 2021
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
jstarry
force-pushed
the
versioned-message
branch
from
2e0e1be to
ed480df
Compare
stale
bot
removed
the
stale
jstarry
force-pushed
the
versioned-message
branch
2 times, most recently
from
59b24ac to
37db41b
Compare
|
Any other concerns here before merging? I have changes ready that build on this |
3 tasks
|
@mvines any high level feedback on this? |
mvines
reviewed
Aug 9, 2021
mvines
reviewed
Aug 9, 2021
mvines
previously approved these changes
Aug 9, 2021
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
Fix comment
jstarry
force-pushed
the
versioned-message
branch
from
a433974 to
fa2df7e
Compare
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
jstarry
force-pushed
the
versioned-message
branch
from
92d0e55 to
5ad1a3d
Compare
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need a new message format for processing transactions that load accounts from an on-chain address map. Also need a way to differentiate this new message from the legacy transaction message format.
Summary of Changes
VersionedMessagewhich has custom serialization to determine which message version to deserialize by inspecting the first byte.v0::Messagewhich supports address maps and is serialized with version == 0Fixes #