Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

replay stage feed back program cost (backport #17731) #18694

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 15, 2021

This is an automatic backport of pull request #17731 done by Mergify.
Cherry-pick of ae27fcb has failed:

On branch mergify/bp/v1.7/pr-17731
Your branch is up to date with 'origin/v1.7'.

You are currently cherry-picking commit ae27fcbcd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   banking-bench/src/main.rs
	new file:   core/src/execute_cost_table.rs
	modified:   core/src/replay_stage.rs
	modified:   core/src/tpu.rs
	modified:   core/src/tvu.rs
	modified:   core/src/validator.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   core/benches/banking_stage.rs
	both modified:   core/src/banking_stage.rs
	deleted by us:   core/src/cost_model.rs
	deleted by us:   core/src/cost_tracker.rs
	both modified:   core/src/lib.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* replay stage feeds back realtime per-program execution cost to cost model;

* program cost execution table is initialized into empty table, no longer populated with hardcoded numbers;

* changed cost unit to microsecond, using value collected from mainnet;

* add ExecuteCostTable with fixed capacity for security concern, when its limit is reached, programs with old age AND less occurrence will be pushed out to make room for new programs.

(cherry picked from commit ae27fcb)

# Conflicts:
#	core/benches/banking_stage.rs
#	core/src/banking_stage.rs
#	core/src/cost_model.rs
#	core/src/cost_tracker.rs
#	core/src/lib.rs
@mergify mergify bot added conflicts automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Jul 15, 2021
@mergify
Copy link
Contributor Author

mergify bot commented Jul 15, 2021

automerge label removed due to a CI failure

@tao-stones
Copy link
Contributor

pull from 1.7, aiming 1.8

@tao-stones tao-stones closed this Jul 15, 2021
@mergify mergify bot deleted the mergify/bp/v1.7/pr-17731 branch July 15, 2021 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant