This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add incremental snapshots to RPC #17749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CriesofCarrots Are you the right person to take a look at this? I noticed your name on many lines of After RPC, I'll be adding ISS stuffs to the gossip service as well. |
|
@brooksprumo , sure, I'll take a look! |
|
Looks fine from the rpc/client perspective. (And also draws my attention to the fact that the client is supporting some long-dead rpc methods... prob time to remove! Thx) |
|
@CriesofCarrots Thanks for taking a look! |
|
Link-back: Related to #17088 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting up this draft PR to get feedback on what's required to add Incremental Snapshots to RPC, for downloading an ISS.
Note: It will not build since the backing ISS code is not in here, and thus the checks will fail.