writes epoch-slots to crds table synchronously #17719
Conversation
epoch-slots may be overwritten before they are written to crds table: solana-labs#17711 This commit writes new epoch-slots to crds table synchronously with push_epoch_slots. The functions is still not thread-safe as commented in the code, however currently only one threads is invoking this code.
|
Awesome, thanks, this unblocks me 😃 Can we also remove the flushes in this test here: https://github.com/solana-labs/solana/blob/master/gossip/src/cluster_info.rs#L4137-L4139 (the test passes now without those flushes) to enforce this guarantee that sequential writes don't overwrite each other even without an intermediary flush? |
Codecov Report
@@ Coverage Diff @@
## master #17719 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 431 431
Lines 120590 120590
=========================================
- Hits 99839 99835 -4
- Misses 20751 20755 +4 |
good point, done |
epoch-slots may be overwritten before they are written to crds table: #17711 This commit writes new epoch-slots to crds table synchronously with push_epoch_slots. The functions is still not thread-safe as commented in the code, however currently only one threads is invoking this code. (cherry picked from commit 60b0a13)
epoch-slots may be overwritten before they are written to crds table: #17711 This commit writes new epoch-slots to crds table synchronously with push_epoch_slots. The functions is still not thread-safe as commented in the code, however currently only one threads is invoking this code. (cherry picked from commit 60b0a13) Co-authored-by: behzad nouri <[email protected]>
Problem
epoch-slots may be overwritten before they are written to crds table:
#17711
Summary of Changes
This commit writes new epoch-slots to crds table synchronously with
push_epoch_slots. The functions is still not thread-safe as commented in
the code, however currently only one threads is invoking this code.