This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Be less fancy for bash 4.4 compat #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Co-authored-by: Jon Cinque <[email protected]>
steviez
pushed a commit
to steviez/solana
that referenced
this pull request
Jun 17, 2024
Add log to unreachable macro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not able to find any references to why the old code doesn't work in bash 4.4, and see other similar code patterns in the repo that do work in bash 4.4 so 🤷♂️.