rpc: add context toggle to getProgramAccounts #17399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00nktk
force-pushed
the
get-program-accs-with-ctx
branch
from
8d4976f to
d575af4
Compare
mvines
reviewed
May 22, 2021
cli/src/cluster_query.rs
Outdated
| @@ -1681,6 +1681,7 @@ pub fn process_show_stakes( | |||
| encoding: Some(solana_account_decoder::UiAccountEncoding::Base64), | |||
| ..RpcAccountInfoConfig::default() | |||
| }, | |||
| with_context: None, | |||
There was a problem hiding this comment.
How about this instead:
..RpcProgramAccountsConfig::default()
so we don't need to touch all these places the next time a new field is added. In some cases it looks like doing so would allow us to remove filters: None, too
00nktk
force-pushed
the
get-program-accs-with-ctx
branch
from
d575af4 to
76daa23
Compare
00nktk
force-pushed
the
get-program-accs-with-ctx
branch
from
76daa23 to
745ec5c
Compare
|
Nice, I bet there are a few other rpc methods that could take advantage of |
mvines
reviewed
May 22, 2021
mvines
reviewed
May 22, 2021
Co-authored-by: Michael Vines <[email protected]>
mvines
previously approved these changes
May 22, 2021
Co-authored-by: Michael Vines <[email protected]>
Thanks! Glad to help! |
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
Downstream projects build fix landing via https://github.com/solana-labs/solana-program-library/pull/1766/files, once it does I'll retrigger the failed build here |
Codecov Report
@@ Coverage Diff @@
## master #17399 +/- ##
=========================================
- Coverage 82.8% 82.7% -0.1%
=========================================
Files 424 424
Lines 118541 118554 +13
=========================================
- Hits 98205 98150 -55
- Misses 20336 20404 +68 |
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2021
* fix(rpc): return context in get_program_accounts * doc(rpc): document withContext flag * fix(rpc): fix comment Co-authored-by: Michael Vines <[email protected]> * fix(rpc): fix doc Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]> (cherry picked from commit d41266e)
mergify bot
added a commit
that referenced
this pull request
May 22, 2021
* fix(rpc): return context in get_program_accounts * doc(rpc): document withContext flag * fix(rpc): fix comment Co-authored-by: Michael Vines <[email protected]> * fix(rpc): fix doc Co-authored-by: Michael Vines <[email protected]> Co-authored-by: Michael Vines <[email protected]> (cherry picked from commit d41266e) Co-authored-by: Nikita <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way in current implementation to get
getProgramAccountsresponse with context.Summary of Changes
Added an optional flag (
with_context) ingetProgramAccountsconfig to set the format of the response. The implementation is simple: if it is present and istrue, the response will be wrapped in RpcResponse, otherwise it defaults to array. While it feels like returning RpcResponse should be the default behavior, there is a big chance that someone relies on the current format of the API. This might seem like not the most elegant solution, but it's backwards compatible.