This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Fix InvokeContext::push() account_deps #17350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still WIP as I would like to have the unit tests to detect this condition as well. |
Lichtso
force-pushed
the
fix/invoke_context_push_account_deps
branch
from
a74f97a to
c111e0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #17350 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 424 424
Lines 118348 118341 -7
=======================================
+ Hits 97891 97903 +12
+ Misses 20457 20438 -19 |
…pf_upgrade_via_cpi.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #17284
Summary of Changes
Reverts aliasing of
account_depswith the previous invocation stack frame inInvokeContext::push().Fixes #17284
Fixes #17135
Fixes #17083