Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log roots range metric #16636

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Apr 19, 2021

Problem

On some validators, old roots are not getting cleaned. We now track min root, so we can calculate a range. The range of roots could be useful information.

Summary of Changes

Log the range of roots that are currently in memory on a validator.

Fixes #

@jeffwashington jeffwashington force-pushed the range_metric branch 2 times, most recently from 9f12310 to 5e35a54 Compare April 19, 2021 19:06
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #16636 (5ff1769) into master (f59fe41) will decrease coverage by 0.0%.
The diff coverage is 96.6%.

@@            Coverage Diff            @@
##           master   #16636     +/-   ##
=========================================
- Coverage    83.0%    82.9%   -0.1%     
=========================================
  Files         418      418             
  Lines      116116   116168     +52     
=========================================
+ Hits        96388    96402     +14     
- Misses      19728    19766     +38     

@jeffwashington jeffwashington marked this pull request as ready for review April 20, 2021 15:00
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
carllin
carllin previously approved these changes Apr 22, 2021

Unverified

No user is associated with the committer email.
@jeffwashington jeffwashington added the automerge Merge this Pull Request automatically once CI passes label Apr 23, 2021
@mergify mergify bot dismissed carllin’s stale review April 23, 2021 14:44

Pull request has been modified.

@mergify mergify bot merged commit 1cc9a1c into solana-labs:master Apr 23, 2021
@jeffwashington
Copy link
Contributor Author

some log entries:
datapoint: accounts_index_roots_len roots_len=391303i uncleaned_roots_len=1i previous_uncleaned_roots_len=391302i roots_range_width=1791086i not_a_root_cleaned=0i cleaned_roots=69674i
datapoint: accounts_index_roots_len roots_len=391270i uncleaned_roots_len=1i previous_uncleaned_roots_len=0i roots_range_width=1791086i not_a_root_cleaned=0i cleaned_roots=33i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants