Use slot 1 for tests' sample store and accounts #16494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anticipating the removal of the old account hashing way, the Account DB tests use slot 0 for the sample storages and accounts data. Slot 0 is a special case, and so to make future changes not break any tests, update just the tests here now to use any other slot. The golden hash values were obtained by running `cargo test` and copying in the "actual" values from the test output into the `raw_expected` vector of the test code. Validated by running `cargo test` successfully.
jeffwashington
approved these changes
Apr 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #16494 +/- ##
========================================
Coverage 80.0% 80.1%
========================================
Files 412 412
Lines 111419 111774 +355
========================================
+ Hits 89240 89573 +333
- Misses 22179 22201 +22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Anticipating the removal of the old account hashing way, the Account DB
tests use slot 0 for the sample storages and accounts data. Slot 0 is a
special case, and so to make future changes not break any tests, update
just the tests here now to use any other slot.
The golden hash values were obtained by running
cargo testand copyingin the "actual" values from the test output into the
raw_expectedvector of the test code.
Summary of Changes
Use slot 1 for tests' sample store and accounts
Validated by running
cargo testsuccessfully.(This work is referencing my previous PR #16442)