Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes test_pull_request_time_pruning smaller #16128

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

behzadnouri
Copy link
Contributor

Problem

test_pull_request_time_pruning seems flaky on ci.
Locally the test always passes, but probably on buildkite it takes longer time and some of the crds values hit their timeout, and so the first assert fails.

Summary of Changes

Made the test smaller.

@behzadnouri behzadnouri requested review from sakridge and utsl42 March 25, 2021 15:48
sakridge
sakridge previously approved these changes Mar 25, 2021
Copy link
Member

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Mar 25, 2021
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Mar 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2021

automerge label removed due to a CI failure

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Mar 25, 2021
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Mar 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2021

automerge label removed due to a CI failure

@behzadnouri behzadnouri force-pushed the flaky-pull-request-test branch from ba8d956 to 57f6331 Compare March 25, 2021 17:30
@mergify mergify bot dismissed sakridge’s stale review March 25, 2021 17:31

Pull request has been modified.

@behzadnouri behzadnouri force-pushed the flaky-pull-request-test branch from 57f6331 to 3546547 Compare March 25, 2021 21:14
@behzadnouri behzadnouri merged commit b041b55 into solana-labs:master Mar 25, 2021
@behzadnouri behzadnouri deleted the flaky-pull-request-test branch March 25, 2021 22:44
mergify bot pushed a commit that referenced this pull request Mar 25, 2021
mergify bot added a commit that referenced this pull request Mar 26, 2021
(cherry picked from commit b041b55)

Co-authored-by: behzad nouri <[email protected]>
mergify bot pushed a commit that referenced this pull request Apr 3, 2021
mergify bot added a commit that referenced this pull request Apr 3, 2021
(cherry picked from commit b041b55)

Co-authored-by: behzad nouri <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants