-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makes test_pull_request_time_pruning smaller #16128
Merged
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:flaky-pull-request-test
Mar 25, 2021
Merged
makes test_pull_request_time_pruning smaller #16128
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:flaky-pull-request-test
Mar 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
previously approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
behzadnouri
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 25, 2021
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 25, 2021
automerge label removed due to a CI failure |
behzadnouri
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 25, 2021
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 25, 2021
automerge label removed due to a CI failure |
behzadnouri
force-pushed
the
flaky-pull-request-test
branch
from
March 25, 2021 17:30
ba8d956
to
57f6331
Compare
behzadnouri
force-pushed
the
flaky-pull-request-test
branch
from
March 25, 2021 21:14
57f6331
to
3546547
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
(cherry picked from commit b041b55)
mergify bot
added a commit
that referenced
this pull request
Mar 26, 2021
(cherry picked from commit b041b55) Co-authored-by: behzad nouri <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2021
(cherry picked from commit b041b55)
mergify bot
added a commit
that referenced
this pull request
Apr 3, 2021
(cherry picked from commit b041b55) Co-authored-by: behzad nouri <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
test_pull_request_time_pruning
seems flaky on ci.Locally the test always passes, but probably on buildkite it takes longer time and some of the crds values hit their timeout, and so the first assert fails.
Summary of Changes
Made the test smaller.