Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase window size #1578

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Increase window size #1578

merged 1 commit into from
Oct 23, 2018

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 23, 2018

Addresses the following problem

  • Validators are not able to keep up with the leader
  • The future blobs (outside of window) get dropped
  • The validators won't process repair requests for these future blobs

Addresses the following problem
- Validators are not able to keep up with the leader
- The future blobs (outside of window) get dropped
- The validators won't process repair requests for these future blobs
@pgarg66
Copy link
Contributor Author

pgarg66 commented Oct 23, 2018

#1508

@garious garious requested a review from rob-solana October 23, 2018 17:17
Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this change, but it looks like a workaround. It leaves me wondering why the data structure is Window of Blob and not Window of Blobs per Tick.

@pgarg66 pgarg66 merged commit bbb38ac into solana-labs:master Oct 23, 2018
@pgarg66 pgarg66 deleted the window branch October 23, 2018 17:25
@rob-solana
Copy link
Contributor

window of blob is historical, and for erasure to function as-is, necessary. ticks are also erasure-coded...

jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 3, 2024
* build(deps): bump borsh from 1.5.0 to 1.5.1

Bumps [borsh](https://github.com/near/borsh-rs) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/near/borsh-rs/releases)
- [Changelog](https://github.com/near/borsh-rs/blob/master/CHANGELOG.md)
- [Commits](near/borsh-rs@borsh-v1.5.0...borsh-v1.5.1)

---
updated-dependencies:
- dependency-name: borsh
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update all Cargo files

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants