Lazy calculate hash for accounts stored in the cache #15617
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While processing a slot, the same account can be written to many times.
Hashing accounts is not free and gets expensive with large data. Hashing an account that is not the final update does not appear to be necessary.
Summary of Changes
When an account is stored to the cache, don't hash the contents first - instead use the default hash. When behavior requires a hash, calculate it when necessary. Ideally, once we calculate it, it would be stored in the cache. I don't know enough yet about the race conditions possible in the cache to attempt to update the cached entry with a new hash. I can work on that if we decide this is optimization overall is useful.
Fixes #