Fix finalize_dead_slot_removal() of cached slots decrementing refcount #15534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15534 +/- ##
=========================================
- Coverage 80.2% 80.2% -0.1%
=========================================
Files 406 406
Lines 103911 104179 +268
=========================================
+ Hits 83374 83587 +213
- Misses 20537 20592 +55 |
ryoqun
reviewed
Feb 26, 2021
runtime/src/accounts_db.rs
Outdated
| @@ -3946,17 +3946,19 @@ impl AccountsDb { | |||
| &'a self, | |||
| dead_slots_iter: impl Iterator<Item = &'a Slot> + Clone, | |||
| purged_slot_pubkeys: HashSet<(Slot, Pubkey)>, | |||
| mut purged_account_slots: Option<&mut AccountSlots>, | |||
| // If the slot being are not cached, return | |||
| is_cached: Option<&mut AccountSlots>, | |||
There was a problem hiding this comment.
nits: keep original var name? This paused me a whil because the type isn't bool.
mergify bot
added a commit
that referenced
this pull request
Feb 27, 2021
#15534) (#15570) (cherry picked from commit 97eaf3c) Co-authored-by: carllin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
finalize_dead_slot_removal() decrements the ref count of deleted account for cached slots, even though the ref count was never incremented for accounts in the cache anyways.
Summary of Changes
Don't decrement the ref count when purging dead cached slots
Fixes #