Refactoring: Move KeyedAccounts to InvokeContext#15410

Merged

Lichtso merged 33 commits intosolana-labs:masterfrom Lichtso:refactor/Move_KeyedAccounts_to_InvokeContext

Apr 19, 2021

+1,503-1,403

Commits on Apr 19, 2021

Adds keyed_accounts property and getter to InvokeContext.
Lichtso
committed
Adds keyed_accounts parameter to MockInvokeContext constructor.
Lichtso
committed
Adds keyed_accounts parameter to ThisInvokeContext constructor.
Lichtso
committed
Replaces next_keyed_account() by keyed_account_at_index()
Lichtso
committed
Adds "&keyed_accounts[1..]" expressions to invoke_context.
Lichtso
committed
Save and restore invoke_context.keyed_accounts in message_processor::process_cross_program_instruction()
Lichtso
committed
Debug assert equality of old and new way of keyed_accounts.
Lichtso
committed
Changes bpf_loader::create_and_cache_executor() to use account indices not references.
Lichtso
committed
Splits off caching part from bpf_loader::create_and_cache_executor().
Lichtso
committed
Changes bpf_loader::write_program_data() to use account indices not references.
Lichtso
committed
Removes callers_keyed_accounts from SyscallInvokeSigned.
Lichtso
committed
Changes message_processor::native_invoke() to use account indices not references.
Lichtso
committed
Removed use of the keyed_accounts parameter in bpf_loader::process_loader_upgradeable_instruction().
Lichtso
committed
Removed use of the keyed_accounts parameter in bpf_loader::process_loader_instruction() and in bpf_loader::Executor::execute().
Lichtso
committed
Removed use of the keyed_accounts parameter in bpf_loader::process_instruction(), bpf_loader::process_instruction_jit() and bpf_loader::process_instruction_common().
Lichtso
committed
Removes unused keyed_accounts parameter in bpf_loader.
Lichtso
committed
Adds more assertions of invoke_context.get_keyed_accounts() being equal to the keyed_accounts parameter.
Lichtso
committed
Changes all native programs to use "invoke_context.get_keyed_accounts()".
Lichtso
committed
Removes the "keyed_accounts" parameter from all "process_instruction" functions.
Lichtso
committed
Fixes test of process_cross_program_instruction() to include keyed_accounts.
Lichtso
committed
Moves InvokeContext::set_keyed_accounts() into push() and pop().
Lichtso
committed
Renames pop_first_keyed_account => remove_first_keyed_account
Lichtso
committed
Merges InvokeContext keyed_accounts and program_ids into invoke_stack.
Lichtso
committed
Removes unprotected integer arithmetic.
Lichtso
committed
Replaces unwrap() by Result.
Lichtso
committed
Replaces tuple by struct.
Lichtso
committed
Replaces slice reference by Vec.
Lichtso
committed
Use ranges instead of removing elements from Vec.
Lichtso
committed
Moves MessageProcessor::create_keyed_accounts() and MessageProcessor::create_pre_accounts() in InvokeContext::new().
Lichtso
committed
Recycle existing keys in ThisInvokeContext::push()
Lichtso
committed
Unifies create_keyed_is_signer_accounts() and create_keyed_readonly_accounts() into create_keyed_accounts_unified().
Lichtso
committed
Makes unsafe transmute more obvious.
Lichtso
committed
Silence warnings about missing "dyn" before traits.
Lichtso
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring: Move KeyedAccounts to InvokeContext#15410

Commits on Apr 19, 2021

Adds keyed_accounts property and getter to InvokeContext.

Adds keyed_accounts parameter to MockInvokeContext constructor.

Adds keyed_accounts parameter to ThisInvokeContext constructor.

Replaces next_keyed_account() by keyed_account_at_index()

Adds "&keyed_accounts[1..]" expressions to invoke_context.

Save and restore invoke_context.keyed_accounts in message_processor::process_cross_program_instruction()

Debug assert equality of old and new way of keyed_accounts.

Changes bpf_loader::create_and_cache_executor() to use account indices not references.

Splits off caching part from bpf_loader::create_and_cache_executor().

Changes bpf_loader::write_program_data() to use account indices not references.

Removes callers_keyed_accounts from SyscallInvokeSigned.

Changes message_processor::native_invoke() to use account indices not references.

Removed use of the keyed_accounts parameter in bpf_loader::process_loader_upgradeable_instruction().

Removed use of the keyed_accounts parameter in bpf_loader::process_loader_instruction() and in bpf_loader::Executor::execute().

Removed use of the keyed_accounts parameter in bpf_loader::process_instruction(), bpf_loader::process_instruction_jit() and bpf_loader::process_instruction_common().

Removes unused keyed_accounts parameter in bpf_loader.

Adds more assertions of invoke_context.get_keyed_accounts() being equal to the keyed_accounts parameter.

Changes all native programs to use "invoke_context.get_keyed_accounts()".

Removes the "keyed_accounts" parameter from all "process_instruction" functions.

Fixes test of process_cross_program_instruction() to include keyed_accounts.

Moves InvokeContext::set_keyed_accounts() into push() and pop().

Renames pop_first_keyed_account => remove_first_keyed_account

Merges InvokeContext keyed_accounts and program_ids into invoke_stack.

Removes unprotected integer arithmetic.

Replaces unwrap() by Result.

Replaces tuple by struct.

Replaces slice reference by Vec.

Use ranges instead of removing elements from Vec.

Moves MessageProcessor::create_keyed_accounts() and MessageProcessor::create_pre_accounts() in InvokeContext::new().

Recycle existing keys in ThisInvokeContext::push()

Unifies create_keyed_is_signer_accounts() and create_keyed_readonly_accounts() into create_keyed_accounts_unified().

Makes unsafe transmute more obvious.

Silence warnings about missing "dyn" before traits.