Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to stabilize the test suite #1525

Closed
wants to merge 1 commit into from

Conversation

garious
Copy link
Contributor

@garious garious commented Oct 17, 2018

The integration tests are allowed to open sockets, so running them
in parallel may cause "Too many open files" errors. This patch
runs the unit tests in parallel and the integration test serially.

@garious garious requested a review from rob-solana October 17, 2018 09:29
@garious
Copy link
Contributor Author

garious commented Oct 17, 2018

@carllin, fyi

The integration tests are allowed to open sockets, so running them
in parallel may cause "Too many open files" errors. This patch
runs the unit tests in parallel and the integration test serially.
@garious garious force-pushed the stabilize-testsuite branch from 7101b86 to ff4c974 Compare October 17, 2018 14:23
@garious
Copy link
Contributor Author

garious commented Oct 17, 2018

@rob-solana, can you provide a portable command to get the filenames without extensions into cargo with --test= prefixes? Preferably that appeases shellcheck.

Current patch causes this error on Ubuntu:

find: Must separate multiple arguments to -type using: ','
--
  | error: Found argument '--' which wasn't expected, or isn't valid in this context
  |  
  | USAGE:
  | cargo test --jobs <N> --verbose

@rob-solana
Copy link
Contributor

working on it

@garious garious closed this Oct 17, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
tao-stones added a commit to tao-stones/solana that referenced this pull request May 30, 2024
…1525)

Add loaded_accounts_stats to TransactionResults, so call sites can access stats of loaded accounts for sanitized transactions; Such stats include the actual loaded-accounts-data-size, count of loaded accounts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants