Bail on all CPI errors #14500
Merged
Bail on all CPI errors #14500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
added
v1.4
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
jackcmay
force-pushed
the
bail-on-all-cpi-errors
branch
from
960b534 to
7b89a58
Compare
jackcmay
force-pushed
the
bail-on-all-cpi-errors
branch
from
7b89a58 to
9313311
Compare
Codecov Report
@@ Coverage Diff @@
## master #14500 +/- ##
=========================================
- Coverage 80.4% 80.3% -0.1%
=========================================
Files 401 401
Lines 99877 99876 -1
=========================================
- Hits 80306 80287 -19
- Misses 19571 19589 +18 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2021
* Bail on all CPI errors * whitespace (cherry picked from commit ec48631) # Conflicts: # programs/bpf/rust/invoke/src/lib.rs # programs/bpf_loader/src/syscalls.rs # sdk/src/feature_set.rs
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2021
* Bail on all CPI errors * whitespace (cherry picked from commit ec48631)
jackcmay
added a commit
that referenced
this pull request
Jan 9, 2021
* Bail on all CPI errors * whitespace (cherry picked from commit ec48631)
mergify bot
added a commit
that referenced
this pull request
Jan 9, 2021
* Bail on all CPI errors * whitespace (cherry picked from commit ec48631) Co-authored-by: Jack May <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jan 10, 2021
* Bail on all CPI errors (#14500) * Bail on all CPI errors * whitespace (cherry picked from commit ec48631) * resolve conflicts Co-authored-by: Jack May <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A program called via CPI might call other programs and then fail gracefully. If that happens the original caller will not have the updated account data from the other called programs and thus will fail runtime checks when it returns.
Summary of Changes
Bail immediately on all failed CPI invocations.
Fixes #