Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology fixes #14112

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Terminology fixes #14112

merged 2 commits into from
Dec 14, 2020

Conversation

jeffwashington
Copy link
Contributor

Problem

1 bad link
A few missing links

Summary of Changes

Fix bad link
Add missing links

Fixes #

@jeffwashington
Copy link
Contributor Author

@mvines
Here is attempt #1.

@mvines
Copy link
Member

mvines commented Dec 14, 2020

Looks good to me. Any reason this is a Draft PR? It looks ready to land

@jeffwashington jeffwashington marked this pull request as ready for review December 14, 2020 21:00
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why Travis CI didn't run on this PR, nothing seems strange https://travis-ci.com/github/solana-labs/solana/requests beyond the fact that this PR isn't listed. Might just be a github->travis webhook blip.

I added the v1.4 label here, so that this PR will be backported to the v1.4 branch automatically and thus show up on docs.solana.com after we ship 1.4.17

@mvines mvines added the v1.4 label Dec 14, 2020
@mvines mvines merged commit 42be09a into solana-labs:master Dec 14, 2020
mergify bot pushed a commit that referenced this pull request Dec 14, 2020
(cherry picked from commit 42be09a)
mergify bot added a commit that referenced this pull request Dec 14, 2020
(cherry picked from commit 42be09a)

Co-authored-by: Jeff Washington (jwash) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants