Return errors to client via jsonrpc #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See solana-labs#1157 for details. The `from` account should be cloned before execute_transaction(), and that's the only one that should be stored if there's an error executing the program.
mvines
approved these changes
Sep 26, 2018
Merged
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…labs#1361) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.15.2 to 4.16.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.16.1/packages/parser) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the client could not tell the difference between a transaction that's been seen by the network, and one that failed because of a bug in its program. With this patch, the client can detect if the transaction was not seen, whether it succeed, or how the the transaction failed. Missing bits of information that still exist:
Also updated the test about potentially desirable behavior (cc #1157). The only part that's undesirable now is that the bank isn't taking the fee when it knows the transaction's program failed. It should.
One thing I don't like about this PR is that it shares too much information with the client. jsonrpc should probably define a separate error structure similar to BankError and maintain backward compatibility.
Fixes #1298