Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard pre hard fork persisted tower if hard-forking #13536

Merged

Conversation

carllin
Copy link
Contributor

@carllin carllin commented Nov 11, 2020

Problem

Taking over: #13527

Summary of Changes

Nits and commented out seemingly unnecessary check: https://github.com/solana-labs/solana/pull/13527/files#r521663621
Fixes #

@carllin carllin added the v1.4 label Nov 11, 2020
@carllin carllin requested a review from ryoqun November 11, 2020 22:04
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #13536 (d56bef6) into master (58354d1) will decrease coverage by 0.0%.
The diff coverage is 6.6%.

@@            Coverage Diff            @@
##           master   #13536     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         378      378             
  Lines       90603    90627     +24     
=========================================
+ Hits        74435    74439      +4     
- Misses      16168    16188     +20     

Copy link
Contributor

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for cleaning!

@ryoqun ryoqun merged commit 9821a77 into solana-labs:master Nov 12, 2020
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
* Discard pre hard fork persisted tower if hard-forking

* Relax config.require_tower

* Add cluster test

* nits

* Remove unnecessary check

Co-authored-by: Ryo Onodera <[email protected]>
Co-authored-by: Carl Lin <[email protected]>
(cherry picked from commit 9821a77)
mergify bot added a commit that referenced this pull request Nov 12, 2020
* Discard pre hard fork persisted tower if hard-forking

* Relax config.require_tower

* Add cluster test

* nits

* Remove unnecessary check

Co-authored-by: Ryo Onodera <[email protected]>
Co-authored-by: Carl Lin <[email protected]>
(cherry picked from commit 9821a77)

Co-authored-by: carllin <[email protected]>
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 4, 2020
)

* Discard pre hard fork persisted tower if hard-forking

* Relax config.require_tower

* Add cluster test

* nits

* Remove unnecessary check

Co-authored-by: Ryo Onodera <[email protected]>
Co-authored-by: Carl Lin <[email protected]>
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 4, 2020
)

* Discard pre hard fork persisted tower if hard-forking

* Relax config.require_tower

* Add cluster test

* nits

* Remove unnecessary check

Co-authored-by: Ryo Onodera <[email protected]>
Co-authored-by: Carl Lin <[email protected]>
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 4, 2020
)

* Discard pre hard fork persisted tower if hard-forking

* Relax config.require_tower

* Add cluster test

* nits

* Remove unnecessary check

Co-authored-by: Ryo Onodera <[email protected]>
Co-authored-by: Carl Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants