RPC: Don't send base64 TXs to old clusters #13047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Oct 21, 2020
t-nelson
force-pushed
the
rpc-base64-tx-fallback
branch
2 times, most recently
from
3ad7291 to
2cd6f6e
Compare
mvines
reviewed
Oct 21, 2020
t-nelson
force-pushed
the
rpc-base64-tx-fallback
branch
from
2cd6f6e to
2bf0cff
Compare
mvines
previously approved these changes
Oct 21, 2020
t-nelson
force-pushed
the
rpc-base64-tx-fallback
branch
from
2bf0cff to
5f54f67
Compare
t-nelson
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #13047 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 364 364
Lines 85498 85530 +32
=======================================
+ Hits 70155 70196 +41
+ Misses 15343 15334 -9 |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are still some pre-1.3.16 development clusters in the wild. They don't like
base64TXs from newer CLIsSummary of Changes
Query the cluster version when sending a TX and encode
base58if it's older than 1.3.16