-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-build-bpf #13040
Add cargo-build-bpf #13040
Conversation
7627252
to
600050d
Compare
Welp looks like I need to rewrite |
Neat, I cherry-picked this PR on top of #12989 and it works!
|
bf9ab9b
to
f67f8e5
Compare
Rewrote
Now wander over to SPL land:
It's smart enough to know when it's not building a cdylib too:
and trying to build something silly produces a reasonable error output:
|
Looking good, nice to see the build scripts tucked under a cargo subcommand |
This is pretty much ready to land, latest commit deletes |
Codecov Report
@@ Coverage Diff @@
## master #13040 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 366 366
Lines 86237 86237
=========================================
- Hits 70878 70869 -9
- Misses 15359 15368 +9 |
ooo, green CI. Now's my chance! |
* Add cargo-build-bpf (cherry picked from commit 07a853d) * Remove do.sh (cherry picked from commit 61be155) Co-authored-by: Michael Vines <[email protected]>
cargo-build-bpf
is a less opinionated version ofsdk/bpf/rust/build.sh
. It:--no-default-features --features program
on youcargo build-bpf ...
solana-install ..
so it just works once you get the solana cli installedExample: build parts of the tree for BPF:
(note: once
program-sdk/
exists (#12989), these extra args disappear)TODO
do.sh
does--dump
flag to obsoletedo.sh dump ...