This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
lastidnotfound step 2: #1300
Merged
lastidnotfound step 2: #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rob-solana
commented
Sep 21, 2018
rob-solana
commented
- move "record stage", aka poh_service into banking stage
rob-solana
commented
Sep 21, 2018
src/banking_stage.rs
Outdated
| if let Err(_) = signal_sender.send(Signal::Transactions(transactions)) { | ||
| return Err(Error::SendError); | ||
| let mut chunk_start = 0; | ||
| while chunk_start != transactions.len() { |
There was a problem hiding this comment.
this doesn't yet compile, so tests aren't here yet. I'm looking for feedback on how better to break this up
|
Cool, good direction. Just try not to make such a mess of |
rob-solana
force-pushed
the
lastidnotfound
branch
from
8c87903 to
2f173ca
Compare
* move "record stage", aka poh_service into banking stage
rewrite entry_next_hash in terms of Poh simplify and unify transaction hashing (no embedded nulls) register_last_entry from banking stage, fixes solana-labs#1171
* new PoH doesn't generate empty ledger entries, so some fixes necessary in multinode tests that rely on that (e.g. giving validators airdrops) * make window repair less patient, if we've been waiting for an answer don't be shy about most recent blobs * delete recorder and record stage * make more verbost thin_client error reporting * more tracing in window (sigh)
rob-solana
force-pushed
the
lastidnotfound
branch
from
b7cb708 to
da847d7
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.30 to 14.14.31. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Jun 13, 2024
* setup tpu client methods required for localcluster to use TpuClient * add new_tpu_quic_client() for local cluster tests * update local-cluster src files to use TpuClient. tests next * finish removing thinclient from localcluster * address comments * add note for send_and_confirm_transaction_with_retries * remove retry logic from tpu-client. Send directly to upcoming leaders without retry.
gregcusack
added a commit
to gregcusack/solana
that referenced
this pull request
Jun 14, 2024
* setup tpu client methods required for localcluster to use TpuClient * add new_tpu_quic_client() for local cluster tests * update local-cluster src files to use TpuClient. tests next * finish removing thinclient from localcluster * address comments * add note for send_and_confirm_transaction_with_retries * remove retry logic from tpu-client. Send directly to upcoming leaders without retry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.