passes through feature-set to gossip requests handling #12878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
changed the title
behzadnouri
force-pushed
the
feature-set
branch
2 times, most recently
from
48747f1 to
4a9d5c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #12878 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 360 361 +1
Lines 84925 85057 +132
=========================================
+ Hits 69580 69682 +102
- Misses 15345 15375 +30 |
mvines
previously approved these changes
Oct 15, 2020
core/src/cluster_info.rs
Outdated
| bank_forks | ||
| .read() | ||
| .unwrap() | ||
| .working_bank() |
There was a problem hiding this comment.
It'll be better to use .root_bank(). With the .working_bank(), we could see a feature get enabled and then disabled again (if the feature happens to get enabled in a minority fork). Otherwise lgtm!
There was a problem hiding this comment.
done.
There are other places in this file which are using .working_bank (e.g. for stakes). Do you think they should also use .root_bank instead?
There was a problem hiding this comment.
I'd say so, but only for consistency. It looks like it shouldn't matter in practice either way though
behzadnouri
force-pushed
the
feature-set
branch
from
4a9d5c8 to
b9eff5b
Compare
behzadnouri
force-pushed
the
feature-set
branch
from
b9eff5b to
de9681d
Compare
carllin
pushed a commit
to carllin/solana
that referenced
this pull request
Oct 17, 2020
…2878) * passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316)
jackcmay
pushed a commit
that referenced
this pull request
Oct 20, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316)
jackcmay
pushed a commit
that referenced
this pull request
Oct 20, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316)
mergify bot
added a commit
that referenced
this pull request
Oct 20, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316) Co-authored-by: behzad nouri <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316)
mergify bot
added a commit
that referenced
this pull request
Oct 27, 2020
* passes through feature-set to down to gossip requests handling * takes the feature-set from root_bank instead of working_bank (cherry picked from commit 4828316) Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For #12794 we want to activate ping/pong check of addresses dynamically once super majority of nodes have updated to the new code. see: #12794 (comment)
Summary of Changes
The commit adds a new feature id for ping/pong check and passes through the feature-set construct down to request handler.