This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix zero-len slice translations #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
force-pushed
the
translate-zero-len-vec
branch
from
ec39014 to
a99cb9c
Compare
jackcmay
added
noCI
Codecov Report
@@ Coverage Diff @@
## master #12642 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 359 359
Lines 83832 83841 +9
=========================================
- Hits 68784 68781 -3
- Misses 15048 15060 +12 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2020
(cherry picked from commit d0aa8a6)
mergify bot
added a commit
that referenced
this pull request
Oct 3, 2020
(cherry picked from commit d0aa8a6) Co-authored-by: Jack May <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zero-length vectors have not been allocated yet so calling as_ptr() returns address 0x1 which is not in the translation map and thus fails with an access violation
Summary of Changes
If translating a zero-length vector then don't attempt to translate
Fixes #